Skip to content

Pre-Course Set Up#26

Merged
adamblanchard merged 22 commits into
mainfrom
self-study-course-after-merge
Apr 23, 2025
Merged

Pre-Course Set Up#26
adamblanchard merged 22 commits into
mainfrom
self-study-course-after-merge

Conversation

@adamblanchard
Copy link
Copy Markdown
Contributor

@adamblanchard adamblanchard commented Apr 23, 2025

I added the "Pre-Course" course, as described in the proposal.

This pr contains:

  1. Pre-Course added
  2. Self-Study pulled out from legacy HTML-CSS module. Only minor wording changes here, nothing else to review.
  3. Technical Application pulled out from gitbook.
  4. PLENTY of linting fixes across the above modules

Context regarding "technical application" - they have previously been created in gitbook by staff, and sent to applicants that way. I have not decided against doing that, but for transparency and better source control, I'm pulling the content into this repo. I have made some structural changes to the markdown files, but no content changes.

What I need reviewing:

  1. That the file structure looks ok
  2. That you don't see any errors from me copying stuff over (broken urls etc.)
  3. NOT on specific content, because all i'm doing here is copying it into this repo. If you do have suggestions though, do note them :-) But probably not worth blocking this pr for!
  4. Other things, if you think of them :D

@adamblanchard adamblanchard changed the title Pre-course set up Pre-course set up (take 2) Apr 23, 2025
@adamblanchard adamblanchard mentioned this pull request Apr 23, 2025
@adamblanchard adamblanchard self-assigned this Apr 23, 2025
@adamblanchard adamblanchard changed the title Pre-course set up (take 2) Pre-Course Set Up Apr 23, 2025
@adamblanchard adamblanchard force-pushed the self-study-course-after-merge branch from 09b5964 to b569585 Compare April 23, 2025 10:44
@adamblanchard adamblanchard marked this pull request as ready for review April 23, 2025 10:47
@adamblanchard adamblanchard requested a review from a team as a code owner April 23, 2025 10:47
@adamblanchard adamblanchard linked an issue Apr 23, 2025 that may be closed by this pull request
4 tasks
@adamblanchard
Copy link
Copy Markdown
Contributor Author

@ahmagdy @urbanogilson you reviewed the last version of this pr i made (#11) if you'd be happy to review this again now it's complete 🙇

@adamblanchard adamblanchard merged commit 6b1fbc3 into main Apr 23, 2025
1 check passed
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamblanchard, I can't find where we use this image in the repo, as well as a few others. Also, it could benefit from compression and webp format. Would it make sense to create a task to review all assets like this?

@rvedotrc rvedotrc deleted the self-study-course-after-merge branch October 15, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

Move modules into new courses that don't need changes

4 participants